Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: improve join / join_on docs #7813

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Oct 12, 2023

Draft as it builds on #7805

Which issue does this PR close?

Related to #7805 and #7766

Rationale for this change

The capabilities of datafusion with joins could be better documented, so let's fix that.

What changes are included in this PR?

Update documentation comments

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added logical-expr Logical plan and expressions core Core DataFusion crate labels Oct 12, 2023
@alamb alamb changed the title Minor: improve join_on docs Minor: improve join / join_on docs Oct 12, 2023
@alamb alamb added the documentation Improvements or additions to documentation label Oct 12, 2023
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Oct 14, 2023
@alamb alamb marked this pull request as ready for review October 16, 2023 14:16
@alamb alamb added the documentation Improvements or additions to documentation label Oct 17, 2023
Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alamb

datafusion/expr/src/logical_plan/builder.rs Outdated Show resolved Hide resolved
Co-authored-by: jakevin <jakevingoo@gmail.com>
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Oct 18, 2023
@alamb
Copy link
Contributor Author

alamb commented Oct 18, 2023

Thanks for the review @jackwener

@alamb alamb merged commit 57f2675 into apache:main Oct 18, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate logical-expr Logical plan and expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants