-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add distinct union optimization #7788
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
SQL Planner
logical-expr
Logical plan and expressions
optimizer
Optimizer rules
sqllogictest
SQL Logic Tests (.slt)
labels
Oct 10, 2023
maruschin
force-pushed
the
add_distinct_union_optimization
branch
from
October 10, 2023 15:21
284f978
to
ea9ddba
Compare
maruschin
force-pushed
the
add_distinct_union_optimization
branch
from
October 11, 2023 01:14
ea9ddba
to
bf5bf24
Compare
maruschin
force-pushed
the
add_distinct_union_optimization
branch
4 times, most recently
from
October 11, 2023 11:40
65a6395
to
af169a1
Compare
maruschin
force-pushed
the
add_distinct_union_optimization
branch
from
October 11, 2023 12:08
af169a1
to
7b01b79
Compare
Thank you @maruschin -- I hope to review this PR tomorrow. I merged up from main, to get the tests from #7787, and I verified that this PR improves the plan. Thank you 🙏 |
alamb
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice @maruschin -- thanks again.
andygrove
added
enhancement
New feature or request
performance
Make DataFusion faster
labels
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
optimizer
Optimizer rules
performance
Make DataFusion faster
sqllogictest
SQL Logic Tests (.slt)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7786.
Related to #7695.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?