Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distinct union optimization #7788

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

maruschin
Copy link
Contributor

@maruschin maruschin commented Oct 10, 2023

Which issue does this PR close?

Closes #7786.
Related to #7695.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt) labels Oct 10, 2023
@maruschin maruschin force-pushed the add_distinct_union_optimization branch from 284f978 to ea9ddba Compare October 10, 2023 15:21
@maruschin maruschin force-pushed the add_distinct_union_optimization branch from ea9ddba to bf5bf24 Compare October 11, 2023 01:14
@github-actions github-actions bot removed sql SQL Planner sqllogictest SQL Logic Tests (.slt) labels Oct 11, 2023
@maruschin maruschin force-pushed the add_distinct_union_optimization branch 4 times, most recently from 65a6395 to af169a1 Compare October 11, 2023 11:40
@github-actions github-actions bot removed the logical-expr Logical plan and expressions label Oct 11, 2023
@maruschin maruschin force-pushed the add_distinct_union_optimization branch from af169a1 to 7b01b79 Compare October 11, 2023 12:08
@maruschin maruschin marked this pull request as ready for review October 11, 2023 12:35
@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Oct 11, 2023
@alamb
Copy link
Contributor

alamb commented Oct 11, 2023

Thank you @maruschin -- I hope to review this PR tomorrow. I merged up from main, to get the tests from #7787, and I verified that this PR improves the plan. Thank you 🙏

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice @maruschin -- thanks again.

@alamb alamb merged commit 81c915c into apache:main Oct 13, 2023
22 checks passed
@maruschin maruschin deleted the add_distinct_union_optimization branch October 17, 2023 01:55
@andygrove andygrove added enhancement New feature or request performance Make DataFusion faster labels Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optimizer Optimizer rules performance Make DataFusion faster sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnest UNION plans (in addition to UNION ALL)
3 participants