Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqllogicaltest: move union.rs #5075

Merged
merged 3 commits into from
Jan 27, 2023
Merged

sqllogicaltest: move union.rs #5075

merged 3 commits into from
Jan 27, 2023

Conversation

jackwener
Copy link
Member

Which issue does this PR close?

move union.rs into sqllogicaltest.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Jan 26, 2023
@jackwener
Copy link
Member Author

jackwener commented Jan 27, 2023

@melgenek thanks your review❤️.
Have resolved them

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jackwener and @melgenek for the review!

@alamb alamb merged commit dd09212 into apache:master Jan 27, 2023
@ursabot
Copy link

ursabot commented Jan 27, 2023

Benchmark runs are scheduled for baseline = fbff8e2 and contender = dd09212. dd09212 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ozankabak
Copy link
Contributor

We seem to be getting CI errors on master, a superficial look suggest it may be related to this.

@jackwener jackwener deleted the sqllogicaltest branch January 28, 2023 03:30
@jackwener
Copy link
Member Author

We seem to be getting CI errors on master, a superficial look suggest it may be related to this.

Is there a related PR?

@jackwener
Copy link
Member Author

I have reproduced this Problem, I will fix it. Thank you @ozankabak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants