-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace &Option<T>
with Option<&T>
#4446
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @askoa
The build failure seems unrelated to this PR. |
Thanks @askoa |
Benchmark runs are scheduled for baseline = 38e9f30 and contender = bde3c91. bde3c91 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Part of #4424
Changed some occurrences of
&Option<T>
withOption<&T>
Are there any user-facing changes?
There might be user facing changes as public functions are modified. Would leave it up to reviewers to add
api-change
tag.