Improve error messages when memory is exhausted while sorting #4348
Conversation
| /// | ||
| /// If the file can not be created for some reason, returns an | ||
| /// error message referencing the request description | ||
| pub fn create_tmp_file(&self, request_description: &str) -> Result<NamedTempFile> { |
There was a problem hiding this comment.
Hopefully once we rework the error handling story, we can move away from this nonsense
|
Benchmark runs are scheduled for baseline = e34c6c3 and contender = 0d65394. 0d65394 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Follow on to #4330
Rationale for this change
The idea is to make it clearer what is going on to a user who sees this error message
What changes are included in this PR?
Implement suggestions from #4330 (comment)
Are these changes tested?
Yes
Are there any user-facing changes?
better error messages