move sql tests from context.rs to corresponding test files in tests/sql
#2329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
approved these changes
Apr 24, 2022
|
Thank you ❤️ @andygrove, I think there is nothing special between test cases in @alamb @yjshen @xudong963 PTAL, thank you. |
alamb
approved these changes
Apr 25, 2022
|
|
||
| let batch = | ||
| RecordBatch::try_new(schema.clone(), vec![str_array, val_array]).unwrap(); | ||
| async fn register_deregister() -> Result<()> { |
There was a problem hiding this comment.
👍 for keeping the variable tests (and others that are related to SessionContext in the same file
| @@ -357,3 +357,240 @@ async fn coalesce_mul_with_default_value() -> Result<()> { | |||
| assert_batches_eq!(expected, &actual); | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| async fn count_basic() -> Result<()> { | |||
There was a problem hiding this comment.
As COUNT and AVG are aggregate functions, these tests probably belong in aggregates.rs or something similar -- we can move them as a follow on PR
gandronchik
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Aug 30, 2022
…s/sql` (apache#2329) * move context.rs ut out * fix clippy * fix fmt
gandronchik
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Aug 31, 2022
…s/sql` (apache#2329) * move context.rs ut out * fix clippy * fix fmt
gandronchik
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Sep 2, 2022
…s/sql` (apache#2329) * move context.rs ut out * fix clippy * fix fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2328 .
Closes #743
Rationale for this change
datafusion/core/src/execution/context.rshas many unmanaged test cases.We can move them to corresponding test files in
datafustion/core/tests/sqlfor better code structure.What changes are included in this PR?
move sql tests from
context.rsto corresponding test files intests/sqlAre there any user-facing changes?
No.