move some tests out of context and into sql #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/test_ballista
branch
from
8943b4f
to
464026d
Compare
alamb
commented
Feb 16, 2022
| @@ -1399,79 +1396,6 @@ mod tests { | |||
| Ok(()) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
context.rs is still 3300 lines ,but it is getting better lol
xudong963
approved these changes
Feb 17, 2022
|
Thank you for the review @xudong963 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
re #743
re #348
Rationale for this change
There are a bunch of tests in execution/context.rs that are not related to
ExecutionContext(they are end to end tests for sql that happen to use the functions inExecutionContext)This both slows down compile times in the
datafusioncrate as well as makes it harder to discover existing test coverage.This was annoying me recently when working in the
contextmodule so I decided to start moving the code over incrementallyWhat changes are included in this PR?
Move a test
Are there any user-facing changes?
No