Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ballista support an optional feature to datafusion-cli #1816

Merged
merged 3 commits into from
Feb 15, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Feb 12, 2022

Which issue does this PR close?

Closes #1815

re #1587

Rationale for this change

See #1815
(basically I want to be able to publish datafusion-cli to crates.io without also publishing ballista)

What changes are included in this PR?

  1. Make ballista an optional feature to datafusion-cli
  2. Add tests to CI to ensure it compiles

Are there any user-facing changes?

need to add --feature=ballista when building datafusion-cli to use it with ballista

N/A

@github-actions github-actions bot added the datafusion Changes in the datafusion crate label Feb 12, 2022
Copy link
Contributor

@liukun4515 liukun4515 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb alamb merged commit 7a2cbd5 into apache:master Feb 15, 2022
@alamb alamb deleted the alamb/datafusion_cli_optional branch February 15, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make ballista an optional dependency of datafusion-cli
2 participants