Remove Accumulator::update and Accumulator::merge
#1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimexist
force-pushed
the
remove-update-merge
branch
2 times, most recently
from
a5c1c70 to
2e2da40
Compare
|
Nice @jimexist -- you beat me to it :) There are a few more instances that need updating -- will see if I can try and help fix it |
jimexist
force-pushed
the
remove-update-merge
branch
from
2e2da40 to
2835eb2
Compare
jimexist
commented
Jan 16, 2022
jimexist
force-pushed
the
remove-update-merge
branch
from
cdb36a9 to
603fe41
Compare
github-actions
bot
added
the
documentation
jimexist
force-pushed
the
remove-update-merge
branch
from
603fe41 to
f9f6fe1
Compare
alamb
reviewed
Jan 16, 2022
alamb
reviewed
Jan 16, 2022
jimexist
force-pushed
the
remove-update-merge
branch
3 times, most recently
from
88797ea to
0f39d02
Compare
alamb
approved these changes
Jan 17, 2022
| } | ||
|
|
||
| impl Accumulator for ArrayAggAccumulator { | ||
| fn update_batch(&mut self, values: &[ArrayRef]) -> Result<()> { |
There was a problem hiding this comment.
I think it would be a good idea as a follow on PR to update these implementations to avoid the use of ScalarValue.
I'll try find some time this week to do it (I need some coding time :) -- lots of reviewing so far)
There was a problem hiding this comment.
let's track this in a GitHub issue
jimexist
force-pushed
the
remove-update-merge
branch
from
0f39d02 to
80d5969
Compare
|
Thanks @jimexist -- this is a great piece of work |
alamb
added
api change
alamb
changed the title
Accumulator::update and Accumulator::merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1549
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?