Skip target in taplo checks #14747
Merged
Skip target in taplo checks #14747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`target` can contain arbitrary files. Contents depend on tools used and tests run, and may even include `Cargo.toml` files that are not properly formatted. The taplo check should never complain on files that are not meant to be part of the repository, and `target` contents clearly falls into that category. `trybuild` is an example of a tool that creates cargo files inside target directory.
xudong963
approved these changes
Feb 18, 2025
BTW i am using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
targetcan contain arbitrary files. Contents depend on tools used and tests run, and may even includeCargo.tomlfiles that are not properly formatted. The taplo check should never complain on files that are not meant to be part of the repository, andtargetcontents clearly falls into that category.trybuildis an example of a tool that creates cargo files inside target directory.