Minor: Refactor benchmark imports to use util module
#12885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated various benchmarks to import `BenchmarkRun`, `CommonOpt`, and `AccessLogOpt` from the `util` module. This improvement organizes and consolidates imports for better maintainability and consistency across the project.
findepi
reviewed
Oct 12, 2024
| @@ -26,7 +26,7 @@ use datafusion::datasource::listing::{ | |||
| use datafusion::datasource::MemTable; | |||
| use datafusion::prelude::CsvReadOptions; | |||
| use datafusion::{arrow::util::pretty, error::Result, prelude::SessionContext}; | |||
| use datafusion_benchmarks::BenchmarkRun; | |||
| use datafusion_benchmarks::util::BenchmarkRun; | |||
There was a problem hiding this comment.
i think the real problem (if any) is that datafusion_benchmarks::BenchmarkRun and datafusion_benchmarks::util::BenchmarkRun are both valid import path.
there are 3 ways to go about it
- stop re-exporting BenchmarkRun from crate root, require
::util:: - make util private, accept only BenchmarkRun import from crate root
- ignore the problem and give up on consistency
There was a problem hiding this comment.
stop re-exporting BenchmarkRun from crate root, require ::util::
I think that is what this PR does which seems reasonable to me
alamb
reviewed
Oct 15, 2024
| @@ -21,5 +21,4 @@ pub mod imdb; | |||
| pub mod parquet_filter; | |||
| pub mod sort; | |||
| pub mod tpch; | |||
| mod util; | |||
| pub use util::*; | |||
| pub mod util; | |||
There was a problem hiding this comment.
this seems like an improvment to me (not re-export everything from util into the banchmark crate namespace
alamb
changed the title
util moduleutil module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on refactoring the import statements across multiple files in the
benchmarksmodule to improve code organization by consolidating utility imports into a single module.Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
yes
Are there any user-facing changes?