Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Update string tests for strpos #12739

Merged
merged 1 commit into from
Oct 4, 2024
+14 −67
Merged

Minor: Update string tests for strpos #12739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions datafusion/sqllogictest/test_files/string/large_string.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,23 +72,6 @@ false false
false true
NULL NULL

# TODO: move it back to `string_query.slt.part` after fixing the issue
# see detail: https://github.com/apache/datafusion/issues/12670
query IIIIII
SELECT
STRPOS(ascii_1, 'e'),
STRPOS(ascii_1, 'ang'),
STRPOS(ascii_1, NULL),
STRPOS(unicode_1, 'и'),
STRPOS(unicode_1, 'ион'),
STRPOS(unicode_1, NULL)
FROM test_basic_operator;
----
5 0 NULL 0 0 NULL
7 3 NULL 0 0 NULL
6 0 NULL 18 18 NULL
NULL NULL NULL NULL NULL NULL

#
# common test for string-like functions and operators
#
Expand Down
17 changes: 0 additions & 17 deletions datafusion/sqllogictest/test_files/string/string.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,23 +63,6 @@ Xiangpeng datafusion数据融合 false true false true
Raphael datafusionДатаФусион false false false false
NULL NULL NULL NULL NULL NULL

# TODO: move it back to `string_query.slt.part` after fixing the issue
# see detail: https://github.com/apache/datafusion/issues/12670
query IIIIII
SELECT
STRPOS(ascii_1, 'e'),
STRPOS(ascii_1, 'ang'),
STRPOS(ascii_1, NULL),
STRPOS(unicode_1, 'и'),
STRPOS(unicode_1, 'ион'),
STRPOS(unicode_1, NULL)
FROM test_basic_operator;
----
5 0 NULL 0 0 NULL
7 3 NULL 0 0 NULL
6 0 NULL 18 18 NULL
NULL NULL NULL NULL NULL NULL

#
# common test for string-like functions and operators
#
Expand Down
30 changes: 14 additions & 16 deletions datafusion/sqllogictest/test_files/string/string_query.slt.part
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,22 +951,20 @@ NULL NULL
# Test STRPOS
# --------------------------------------

# TODO: DictionaryString does not support STRPOS. Enable this after fixing the issue
# see issue: https://github.com/apache/datafusion/issues/12670
#query IIIIII
#SELECT
# STRPOS(ascii_1, 'e'),
# STRPOS(ascii_1, 'ang'),
# STRPOS(ascii_1, NULL),
# STRPOS(unicode_1, 'и'),
# STRPOS(unicode_1, 'ион'),
# STRPOS(unicode_1, NULL)
#FROM test_basic_operator;
#----
#5 0 NULL 0 0 NULL
#7 3 NULL 0 0 NULL
#6 0 NULL 18 18 NULL
#NULL NULL NULL NULL NULL NULL
query IIIIII
SELECT
STRPOS(ascii_1, 'e'),
STRPOS(ascii_1, 'ang'),
STRPOS(ascii_1, NULL),
STRPOS(unicode_1, 'и'),
STRPOS(unicode_1, 'ион'),
STRPOS(unicode_1, NULL)
FROM test_basic_operator;
----
5 0 NULL 0 0 NULL
7 3 NULL 0 0 NULL
6 0 NULL 18 18 NULL
NULL NULL NULL NULL NULL NULL

# --------------------------------------
# Test SUBSTR_INDEX
Expand Down
17 changes: 0 additions & 17 deletions datafusion/sqllogictest/test_files/string/string_view.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,23 +50,6 @@ false false
false true
NULL NULL

# TODO: move it back to `string_query.slt.part` after fixing the issue
# see detail: https://github.com/apache/datafusion/issues/12670
query IIIIII
SELECT
STRPOS(ascii_1, 'e'),
STRPOS(ascii_1, 'ang'),
STRPOS(ascii_1, NULL),
STRPOS(unicode_1, 'и'),
STRPOS(unicode_1, 'ион'),
STRPOS(unicode_1, NULL)
FROM test_basic_operator;
----
5 0 NULL 0 0 NULL
7 3 NULL 0 0 NULL
6 0 NULL 18 18 NULL
NULL NULL NULL NULL NULL NULL

#
# common test for string-like functions and operators
#
Expand Down
Loading