Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create datafusion 6.0.0, ballista 0.6.0 and python 0.4.0 releases #1253

Merged
merged 3 commits into from
Nov 14, 2021
Merged

create datafusion 6.0.0, ballista 0.6.0 and python 0.4.0 releases #1253

merged 3 commits into from
Nov 14, 2021

Conversation

houqp
Copy link
Member

@houqp houqp commented Nov 6, 2021

Rationale for this change

Prepare for the 6.0.0 release.

We have way more changes than I initially expected :D

Also cc @rdettai

What changes are included in this PR?

  • New changelogs
  • Improve release automations

Are there any user-facing changes?

no

@houqp houqp added this to the 6.0.0 milestone Nov 6, 2021
@github-actions github-actions bot added ballista datafusion Changes in the datafusion crate development-process Related to development process of DataFusion labels Nov 6, 2021
@houqp
Copy link
Member Author

houqp commented Nov 6, 2021

I am quite comfortable with the release automation tools and documentation now, I think next time, any committer should be able to run the release so I won't be the only one who is running the releases.

houqp
houqp commented Nov 6, 2021
View reviewed changes
.github_changelog_generator
@@ -18,8 +18,6 @@
# under the License.
#

# point to the old changelog in apache/arrow
front-matter=For older versions, see [apache/arrow/CHANGELOG.md](https://github.com/apache/arrow/blob/master/CHANGELOG.md)\n
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed anymore because it's already included in the 5.0.0 changelog and we are appending 6.0.0 changelog on top of it.

houqp
houqp commented Nov 6, 2021
View reviewed changes
dev/release/README.md
Comment on lines -104 to -114
Create local release rc tags:

```
git tag -f 5.1.0-rc-local
# if there is ballista release
git tag -f ballista-0.5.0-rc-local
# if there is python binding release
git tag -f python-0.3.0-rc-local
```

Manully edit the previous release version tag in
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turns out these local tags are not being used at all in changelog automation.

houqp
houqp commented Nov 6, 2021
View reviewed changes
dev/release/update_change_log.sh
--include-labels "${PROJECT}" \
--base "${OUTPUT_PATH}" \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this argument appends new version changelog to the existing one file instead of overwriting the full history.

@jimexist
Copy link
Member

jimexist commented Nov 6, 2021

thanks for the update @houqp - i guess i can help with releasing next time (or a minor one, like 6.1)

@xudong963
Copy link
Member

xudong963 commented Nov 6, 2021 •
edited
Loading

Nice work 👍🏻@houqp, looking forward to being a committer and running the release, LOL 😁

@alamb alamb mentioned this pull request Nov 6, 2021
Closed
alamb
alamb approved these changes Nov 6, 2021
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great -- thank you very much @houqp ❤️

Do you plan a release blog? I would love to help make one. There are all sorts of cool things I think we could write about in this release (AVRO support, explain analyze, constant folding, hive partitioning support, and the new roadmap

datafusion/CHANGELOG.md

**Breaking changes:**

- Removed deprecated with\_concurrency [\#1200](https://github.com/apache/arrow-datafusion/pull/1200) ([rdettai](https://github.com/rdettai))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot of good stuff in DF 6.0.0 😮

@houqp
Copy link
Member Author

houqp commented Nov 6, 2021

Do you plan a release blog? I would love to help make one.

Please go ahead @alamb ! I won't have time to do this until the release has been cut and voted. We can all collaborate to the blog like the last one @andygrove wrote.

@jimexist
Copy link
Member

jimexist commented Nov 7, 2021

oh by the way after this is cut and release i will help with the homebrew formula update

@houqp
Copy link
Member Author

houqp commented Nov 8, 2021

Going to wait for @xudong963 's set changes for 6.0.0 release since those PRs look pretty complete and mostly ready to merge :)

@andygrove andygrove mentioned this pull request Nov 8, 2021
Closed
@alamb alamb mentioned this pull request Nov 8, 2021
Merged
@alamb
Copy link
Contributor

alamb commented Nov 8, 2021

Please go ahead @alamb ! I won't have time to do this until the release has been cut and voted. We can all collaborate to the blog like the last one @andygrove wrote.

Here is an initial shot: apache/arrow-site#160

I may have missed something

@houqp houqp mentioned this pull request Nov 12, 2021
Merged
@xudong963
Copy link
Member

@houqp Maybe README also need update: https://github.com/apache/arrow-datafusion/blob/master/README.md#using-datafusion-as-a-library

[dependencies]
datafusion = "5.0.0"

to

[dependencies]
datafusion = "6.0.0"

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 13, 2021
@houqp houqp merged commit 7824a8d into apache:master Nov 14, 2021
@houqp
Copy link
Member Author

houqp commented Nov 14, 2021

Thanks @xudong963 for catching that, I have updated the version bump automation to cover README.md going forward.

@houqp houqp deleted the qp_release branch November 14, 2021 01:04
@alamb
Copy link
Contributor

alamb commented Nov 14, 2021

🎉

matthewmturner pushed a commit to matthewmturner/arrow-datafusion that referenced this pull request Nov 16, 2021
@matthewmturner
create datafusion 6.0.0, ballista 0.6.0 and python 0.4.0 releases (ap…
5257304 
…ache#1253)

* create datafusion 6.0.0, ballista 0.6.0 and python 0.4.0 releases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@jimexist jimexist jimexist approved these changes

@Dandandan Dandandan Awaiting requested review from Dandandan

@andygrove andygrove Awaiting requested review from andygrove

@kszucs kszucs Awaiting requested review from kszucs

@jorgecarleitao jorgecarleitao Awaiting requested review from jorgecarleitao

Assignees
No one assigned
Labels
datafusion Changes in the datafusion crate development-process Related to development process of DataFusion documentation Improvements or additions to documentation
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@houqp @jimexist @xudong963 @alamb