Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Fix project website links #12419

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Sep 10, 2024

Which issue does this PR close?

N/A

Rationale for this change

While working on #12418 I noticed that the top most links on https://github.com/apache/datafusion currently were wonky

Screenshot 2024-09-10 at 9 32 38 AM
  1. The project website just linked to the github url
  2. the "guides" link linked to the doc source which doesn't seem all that useful

What changes are included in this PR?

  1. Fix project website link to point at https://datafusion.apache.org/
  2. Remove guide link (they are on the main project website link)

Are these changes tested?

I tested manually. You can see the rendered version here: https://github.com/alamb/datafusion/tree/alamb/self_referential_site?tab=readme-ov-file

Are there any user-facing changes?

Only docs

@alamb alamb added the documentation Improvements or additions to documentation label Sep 10, 2024
[API Docs](https://docs.rs/datafusion/latest/datafusion/) |
[Chat](https://discord.com/channels/885562378132000778/885562378132000781)

<img src="./docs/source/_static/images/2x_bgwhite_original.png" width="512" alt="logo"/>
<a href="https://datafusion.apache.org/">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes it so when you click on the logo on the github repo you go to https://datafusion.apache.org/

If you do this on the current version of https://github.com/apache/datafusion?tab=readme-ov-file you go to

https://github.com/apache/datafusion/blob/main/docs/source/_static/images/2x_bgwhite_original.png

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb

@alamb alamb merged commit f24f2cb into apache:main Sep 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants