Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the CONCAT scalar function to support Utf8View #12224

Merged
merged 18 commits into from
Sep 3, 2024
Merged

Update the CONCAT scalar function to support Utf8View #12224

merged 18 commits into from
Sep 3, 2024
+416 −34

Commits on Aug 28, 2024

  1. wip

    @devanbenz
    devanbenz committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    723ceb7 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. feat: Update the CONCAT scalar function to support Utf8View

    @devanbenz
    devanbenz committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    f7abdd5 View commit details
    Browse the repository at this point in the history

  2. fmt

    @devanbenz
    devanbenz committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    503d5b9 View commit details
    Browse the repository at this point in the history

  3. fmt and add default return type for concat

    @devanbenz
    devanbenz committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    b30330d View commit details
    Browse the repository at this point in the history

  4. fix clippy lint 

    Signed-off-by: Devan <devandbenz@gmail.com>
    @devanbenz
    devanbenz committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    76d6b5f View commit details
    Browse the repository at this point in the history

  5. fmt 

    Signed-off-by: Devan <devandbenz@gmail.com>
    @devanbenz
    devanbenz committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    9798ed3 View commit details
    Browse the repository at this point in the history

  6. add more tests for sqllogic 

    Signed-off-by: Devan <devandbenz@gmail.com>
    @devanbenz
    devanbenz committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    91d04ff View commit details
    Browse the repository at this point in the history

  7. make sure no casting with LargeUtf8

    @devanbenz
    devanbenz committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    6d28927 View commit details
    Browse the repository at this point in the history

  8. fixing utf8large

    @devanbenz
    devanbenz committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    769d99d View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. fix large utf8 

    Signed-off-by: Devan <devandbenz@gmail.com>
    @devanbenz
    devanbenz committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    ac30a83 View commit details
    Browse the repository at this point in the history

  2. fix large utf8 

    Signed-off-by: Devan <devandbenz@gmail.com>
    @devanbenz
    devanbenz committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    7ea6e0a View commit details
    Browse the repository at this point in the history

  3. add test 

    Signed-off-by: Devan <devandbenz@gmail.com>
    @devanbenz
    devanbenz committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    dd3ad39 View commit details
    Browse the repository at this point in the history

  4. fmt 

    Signed-off-by: Devan <devandbenz@gmail.com>
    @devanbenz
    devanbenz committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    504459c View commit details
    Browse the repository at this point in the history

  5. make it so Utf8View just returns Utf8 

    Signed-off-by: Devan <devandbenz@gmail.com>
    @devanbenz
    devanbenz committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    e081934 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2024

  1. wip -- trying to build a stringview with columnar refs 

    Signed-off-by: Devan <devandbenz@gmail.com>
    @devanbenz
    devanbenz committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    0069c1a View commit details
    Browse the repository at this point in the history

  2. built stringview builder but it does allocate a new String each iter :( 

    Signed-off-by: Devan <devandbenz@gmail.com>
    @devanbenz
    devanbenz committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    0929a4b View commit details
    Browse the repository at this point in the history

  3. add some testing 

    Signed-off-by: Devan <devandbenz@gmail.com>
    @devanbenz
    devanbenz committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    f16de44 View commit details
    Browse the repository at this point in the history

  4. clippy 

    Signed-off-by: Devan <devandbenz@gmail.com>
    @devanbenz
    devanbenz committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    d0bf3ba View commit details
    Browse the repository at this point in the history