feat: support upper and lower for stringview #12138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshauck
force-pushed
the
upper-lower-string-view
branch
3 times, most recently
from
5737c20
to
5709f3b
Compare
tshauck
force-pushed
the
upper-lower-string-view
branch
from
5709f3b
to
b4e0974
Compare
tshauck
commented
Aug 23, 2024
| @@ -214,6 +214,23 @@ where | |||
| i64, | |||
| _, | |||
| >(array, op)?)), | |||
| DataType::Utf8View => { | |||
| let string_array = as_string_view_array(array)?; | |||
There was a problem hiding this comment.
Not sure happy with this implementation, but it seems to work. I tried something akin to:
let result = string_array.iter().map(|string| string.map(op));but that seems to require a clone of op which isn't allowed based on the existing function definition, and seems worth avoiding.
There was a problem hiding this comment.
this implemenation looks reasonable to me. Thanks @tshauck
alamb
approved these changes
Aug 24, 2024
| @@ -214,6 +214,23 @@ where | |||
| i64, | |||
| _, | |||
| >(array, op)?)), | |||
| DataType::Utf8View => { | |||
| let string_array = as_string_view_array(array)?; | |||
There was a problem hiding this comment.
this implemenation looks reasonable to me. Thanks @tshauck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11855
Rationale for this change
The Utf8View type are currently cast into Utf8 types. This PR updates the
lower(andupper) functions(s) to support the type natively.What changes are included in this PR?
Added a specific path for Utf8Views to upper and lower.
Are these changes tested?
Yes, updated the
EXPLAINtests to show no cast is performed. Also basic tests to show the actual transformation is done on the utf8view type.Are there any user-facing changes?
No