Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: single partition in SortPreservingMergeExec don't take fetch #12109

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

haohuaijin
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

When SortPreservingMergeExec has only one partition, it directly calls its input to get the result. Therefore, the fetch parameter in SortPreservingMergeExec will have no effect.

so this pr, I reuse the LimitStream in Limit to limit the fetch result in SortPreservingMergeExec.

What changes are included in this PR?

Are these changes tested?

yes, add test for this case

Are there any user-facing changes?

@github-actions github-actions bot added the physical-expr Physical Expressions label Aug 22, 2024
@alamb
Copy link
Contributor

alamb commented Aug 23, 2024

Thank you @haohuaijin and @Dandandan for the review

@alamb alamb merged commit 8fd9d69 into apache:main Aug 23, 2024
24 checks passed
@haohuaijin haohuaijin deleted the fix-sort-merge-single-with-fetch branch August 23, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants