Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: polish Accumulator::state docs #12053

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Minor: polish Accumulator::state docs #12053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions datafusion/expr-common/src/accumulator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ pub trait Accumulator: Send + Sync + Debug {
/// ┌─────────────────────────┐ ┌─────────────────────────┐
/// │ GroubyBy │ │ GroubyBy │
/// │(AggregateMode::Partial) │ │(AggregateMode::Partial) │
/// └─────────────────────────┘ └────────────▲────────────┘
/// ▲ │
/// └─────────────────────────┘ └─────────────────────────┘
/// ▲ ▲
/// │ │ update_batch() is called for
/// │ │ each input RecordBatch
/// .─────────. .─────────.
Expand Down Expand Up @@ -185,15 +185,15 @@ pub trait Accumulator: Send + Sync + Debug {
/// │(AggregateMode::Partial) │ │ (AggregateMode::Partial) │ the groups
/// └─────────────────────────┘ └──────────────────────────┘
/// ▲ ▲
/// │ ┌┘
/// │ │
/// .─────────. .─────────.
/// ,─' '─. ,─' '─.
/// ; Input : ; Input : 1. Since input data is
/// : Partition 0 ; : Partition 1 ; arbitrarily or RoundRobin
/// ╲ ╱ ╲ ╱ distributed, each partition
/// '─. ,─' '─. ,─' likely has all distinct
/// `───────' `───────'
/// │ │
/// │ │
/// .─────────. .─────────.
/// ,─' '─. ,─' '─.
/// ; Input : ; Input : 1. Since input data is
/// : Partition 0 ; : Partition 1 ; arbitrarily or RoundRobin
/// ╲ ╱ ╲ ╱ distributed, each partition
/// '─. ,─' '─. ,─' likely has all distinct
/// `───────' `───────'
/// ```
///
/// This structure is used so that the `AggregateMode::Partial` accumulators
Expand Down