Update ASCII scalar function to support Utf8View #11834 #11884
Merged
+189
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrybugakov
force-pushed
the
update-ascii-utf8view-11834
branch
from
c94858c
to
3dddecc
Compare
XiangpengHao
reviewed
Aug 8, 2024
| let string_array = args[0].as_string_view(); | ||
| calculate_ascii(string_array.iter()) | ||
| } | ||
| _ => unreachable!(), |
There was a problem hiding this comment.
Should we return internal_err!("Unsupported data type") instead of panic here?
XiangpengHao
reviewed
Aug 8, 2024
|
|
||
| fn calculate_ascii<'a, I>(string_array: I) -> Result<ArrayRef> | ||
| where | ||
| I: IntoIterator<Item = Option<&'a str>>, |
There was a problem hiding this comment.
Suggested change
| I: IntoIterator<Item = Option<&'a str>>, | |
| I: ArrayAccessor<Item = &'a str>, |
As exampled in https://github.com/apache/arrow-rs/blob/e28cf44e65cdd1fefaa1b857ca4336e7a9da5d06/arrow-array/src/array/mod.rs#L487-L507
dmitrybugakov
force-pushed
the
update-ascii-utf8view-11834
branch
2 times, most recently
from
e380fa1
to
dad81cf
Compare
dmitrybugakov
force-pushed
the
update-ascii-utf8view-11834
branch
from
dad81cf
to
ea14dbc
Compare
alamb
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Looks great to me -- thank you @dmitrybugakov and @XiangpengHao for the revieww
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11834.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?