Support reading string view stats #11861
Closed
+103
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiangpengHao
commented
Aug 7, 2024
| @@ -493,6 +499,7 @@ async fn fetch_statistics( | |||
| pub fn statistics_from_parquet_meta_calc( | |||
| metadata: &ParquetMetaData, | |||
| table_schema: SchemaRef, | |||
| force_string_view: bool, | |||
There was a problem hiding this comment.
This is not super elegant as we need to pass this config deep into the implementations. But I don't have a better way to do this.
|
FWIW now that we implemented this for real in apache/arrow-rs#6181 (thanks @Kev1n8 🙏 ) do we still need this code (once we have updated to get the changes upstream?) |
|
Marking as draft as I think this PR is no longer waiting on feedback. Please mark it as ready for review when it is ready for another look |
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #11752.
Rationale for this change
Add implementation to support StringView in statistics. This should potentially allow StringView to run faster for parquet files that have good statistics.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?