Second batch of updating sql tests to use assert_batches_eq #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimexist
reviewed
Oct 31, 2021
datafusion/tests/sql.rs
Outdated
| @@ -2102,6 +2116,8 @@ async fn equijoin_and_other_condition() -> Result<()> { | |||
| let sql = | |||
| "SELECT t1_id, t1_name, t2_name FROM t1 JOIN t2 ON t1_id = t2_id AND t2_name >= 'y' ORDER BY t1_id"; | |||
| let actual = execute(&mut ctx, sql).await; | |||
| // let a = execute_to_batches(&mut ctx, sql).await; | |||
| // println!("{}", pretty_format_batches(&a).unwrap()); | |||
There was a problem hiding this comment.
can you either remove this or put a todo on what to do next?
There was a problem hiding this comment.
i just caught up the tracking comment that is used for test porting:
// --- End Test Porting ---
Let me know when you think its enough updates on this batch / PR to merge and ill clean up those helpers so it can be merged.
|
@alamb this should be good amount for another batch - when you get the chance can you give it a review? |
alamb
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Continued work on #743 task 2
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?