Minor: Improve arrow_statistics tests
#10927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jun 15, 2024
| @@ -164,6 +164,36 @@ impl TestReader { | |||
| } | |||
| } | |||
|
|
|||
| /// Which statistics should we check? | |||
There was a problem hiding this comment.
I think this is easier to understand (and now it is at least documented why sometimes the page stats are the same and some they are different)
| assert_eq!( | ||
| &row_counts, &expected_row_counts, | ||
| "{column_name}: Mismatch with expected row counts. \ | ||
| Actual: {row_counts:?}. Expected: {expected_row_counts:?}" | ||
| ); | ||
| } else { | ||
| } |
There was a problem hiding this comment.
The code can now check either or both types of statistics
| // row counts are [5, 5, 5, 5] | ||
| expected_row_counts: UInt64Array::from(vec![5, 5, 5, 5]), | ||
| column_name: "i64", | ||
| check: Check::Both, |
There was a problem hiding this comment.
I thought Both was easier to understand here than the loop -- and will be a better pattern to follow to add supprot for other types
Weijun-H
approved these changes
Jun 16, 2024
|
Thanks everyone for the reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #10922
Rationale for this change
I thought of a way to make the tests easier to write -- which will be important as we start expanding out the test coverage
What changes are included in this PR?
Add an enum to make more explicit what is being testsed
Are these changes tested?
Only tests
Are there any user-facing changes?
No
cc @marvinlanhenke