-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace GetFieldAccess
with indexing function in SqlToRel
#10375
Conversation
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
---- | ||
host1 101 | ||
host2 202 | ||
host3 303 | ||
|
||
# TODO: Issue tracked in https://github.com/apache/datafusion/issues/10364 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the issue from #10364, not a regression caused by this change.
GetFieldAccess
with indexing function in parser
GetFieldAccess
with indexing function in parserGetFieldAccess
with indexing function in SqlToRel
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
cc @westonpace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me -- thank you @jayzhan211 -- I am going to also tag this PR as api change so it gets highlighted in the readme
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Thanks @alamb ! |
…e#10375) * use func in parser Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * add tests Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * add test Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * rm test1 Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * parser done Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * fmt Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * fix exprapi test Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * fix test Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * fix conflicts Signed-off-by: jayzhan211 <jayzhan211@gmail.com> --------- Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Which issue does this PR close?
Part of #10374
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?