Minor: Clarify documentation on PruningStatistics::row_counts and PruningStatistics::null_counts and make test match
#10004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
PruningStatistics::row_counts and PruningStatistics::null_counts and make test match
alamb
commented
Apr 8, 2024
| @@ -1753,13 +1758,13 @@ mod tests { | |||
| self | |||
| } | |||
|
|
|||
| /// Add null counts for the specified columm. | |||
| /// Add null counts for the specified column. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
As @waynexia and @Ted-Jiang noted in #9989 / https://github.com/apache/arrow-datafusion/pull/9989/files#r1555386926 the documentation for https://docs.rs/datafusion/latest/datafusion/physical_optimizer/pruning/trait.PruningStatistics.html#tymethod.row_counts says a
UInt64Arrayshould be returned but the tests return aInt64ArrayWhat changes are included in this PR?
Improve documentation and update tests to do what the docs say should be done
Are these changes tested?
Existing tests
Are there any user-facing changes?
No