Skip to content

Commit

Permalink
[fix] rename create_executor
Browse files Browse the repository at this point in the history
  • Loading branch information
rdettai committed Sep 23, 2021
1 parent 82d1763 commit f85f66e
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions datafusion/src/datasource/file_format/avro.rs
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ impl FileFormat for AvroFormat {
Ok(Statistics::default())
}

async fn create_executor(
async fn create_physical_plan(
&self,
schema: SchemaRef,
files: Vec<Vec<PartitionedFile>>,
Expand Down Expand Up @@ -338,7 +338,7 @@ mod tests {
.expect("Stats inference");
let files = vec![vec![PartitionedFile { path: filename }]];
let exec = format
.create_executor(schema, files, stats, projection, batch_size, &[], None)
.create_physical_plan(schema, files, stats, projection, batch_size, &[], None)
.await?;
Ok(exec)
}
Expand Down
4 changes: 2 additions & 2 deletions datafusion/src/datasource/file_format/csv.rs
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ impl FileFormat for CsvFormat {
Ok(Statistics::default())
}

async fn create_executor(
async fn create_physical_plan(
&self,
schema: SchemaRef,
files: Vec<Vec<PartitionedFile>>,
Expand Down Expand Up @@ -214,7 +214,7 @@ mod tests {
.expect("Stats inference");
let files = vec![vec![PartitionedFile { path: filename }]];
let exec = format
.create_executor(schema, files, stats, projection, batch_size, &[], None)
.create_physical_plan(schema, files, stats, projection, batch_size, &[], None)
.await?;
Ok(exec)
}
Expand Down
4 changes: 2 additions & 2 deletions datafusion/src/datasource/file_format/json.rs
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ impl FileFormat for JsonFormat {
Ok(Statistics::default())
}

async fn create_executor(
async fn create_physical_plan(
&self,
schema: SchemaRef,
files: Vec<Vec<PartitionedFile>>,
Expand Down Expand Up @@ -188,7 +188,7 @@ mod tests {
path: filename.to_owned(),
}]];
let exec = format
.create_executor(schema, files, stats, projection, batch_size, &[], None)
.create_physical_plan(schema, files, stats, projection, batch_size, &[], None)
.await?;
Ok(exec)
}
Expand Down
2 changes: 1 addition & 1 deletion datafusion/src/datasource/file_format/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ pub trait FileFormat: Send + Sync {
/// TODO group params into TableDescription(schema,files,stats) and
/// ScanOptions(projection,batch_size,filters) to avoid too_many_arguments
#[allow(clippy::too_many_arguments)]
async fn create_executor(
async fn create_physical_plan(
&self,
schema: SchemaRef,
files: Vec<Vec<PartitionedFile>>,
Expand Down
4 changes: 2 additions & 2 deletions datafusion/src/datasource/file_format/parquet.rs
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ impl FileFormat for ParquetFormat {
Ok(stats)
}

async fn create_executor(
async fn create_physical_plan(
&self,
schema: SchemaRef,
files: Vec<Vec<PartitionedFile>>,
Expand Down Expand Up @@ -534,7 +534,7 @@ mod tests {
.expect("Stats inference");
let files = vec![vec![PartitionedFile { path: filename }]];
let exec = format
.create_executor(schema, files, stats, projection, batch_size, &[], None)
.create_physical_plan(schema, files, stats, projection, batch_size, &[], None)
.await?;
Ok(exec)
}
Expand Down
2 changes: 1 addition & 1 deletion datafusion/src/datasource/listing.rs
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ impl TableProvider for ListingTable {
// create the execution plan
self.options
.format
.create_executor(
.create_physical_plan(
self.schema(),
partitioned_file_lists,
statistics,
Expand Down

0 comments on commit f85f66e

Please sign in to comment.