-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support pluralized time units #1630
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wugeer
force-pushed
the
feat/add_suppor_days_etc
branch
from
December 31, 2024 15:13
5729338
to
f8b32e6
Compare
iffyio
reviewed
Jan 5, 2025
iffyio
changed the title
add time unit
Support pluralized time units
Jan 5, 2025
SECONDS/MINUTES/HOURS/DAYS/WEEKS/MONTHS/YEARS
for `IN…
iffyio
reviewed
Jan 6, 2025
iffyio
reviewed
Jan 7, 2025
iffyio
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow we have really been picking up steam on reviews in sqlparser. The next relaese is going to be sweet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add time unit
SECONDS/MINUTES/HOURS/DAYS/WEEKS/MONTHS/YEARS
forINTERVAL
typesee