Test benchmarks and Improve benchmark README.md #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansott
added a commit
to hansott/datafusion-sqlparser-rs
that referenced
this pull request
Jan 7, 2025
…o patch-carriage-return * 'main' of github.com:hansott/datafusion-sqlparser-rs: Add support for MySQL's INSERT INTO ... SET syntax (apache#1641) Add support for Snowflake LIST and REMOVE (apache#1639) Add support for the SQL OVERLAPS predicate (apache#1638) Add support for various Snowflake grantees (apache#1640) Add support for USE SECONDARY ROLE (vs. ROLES) (apache#1637) Correctly tokenize nested comments (apache#1629) Add support for MYSQL's `RENAME TABLE` (apache#1616) Test benchmarks and Improve benchmark README.md (apache#1627)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tokens as much #1558If we want people to be able to optimize the parser, they need to
sqlparser_benchbenchmark compilation #1625)Let's document this and add a CI check
You can see the rendered docs here: https://github.com/alamb/sqlparser-rs/tree/alamb/benchmark_docs/sqlparser_bench
Note the CI check is going to fail until we merge #1625
Here is an example failure:
https://github.com/apache/datafusion-sqlparser-rs/actions/runs/12527324324/job/34940794352?pr=1627