Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickhouse SQL generation for datatypes. #1482

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

grigoryan-sergey
Copy link

The SQL generated by the parser does not work inside Clickhouse. The problem is in datatypes, which are case sensitive in Clickhouse. I suggest generating a Clickhouse version for datatypes. This will still work for other databases where datatypes are not case sensitive (like postgres) and will also work for Clickhouse. Interesting enough some datatypes are also not case sensitive in Clickhouse, but the ones which are case sensitive, are converted in the PR.

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @grigoryan-sergey hmm with the current changes I expect a lot of tests to fail since we''ve also changed types that affect other dialects. I wonder if there's a way to support both styles 🤔 (I guess first would be if Clickhouse is the only supported dialect with a different behavior)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants