Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1469 (SET ROLE regression) #1474

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

lovasoa
Copy link
Contributor

@lovasoa lovasoa commented Oct 12, 2024

this fixes a regression that was introduced with the new SetRole statement

@lovasoa
Copy link
Contributor Author

lovasoa commented Oct 12, 2024

Hello !
@alamb , this fixes a regression that had a big impact on SQLPage, where it is common to name a variable role.
Initially reported in sqlpage/SQLPage#644 (reply in thread)

src/parser/mod.rs Outdated Show resolved Hide resolved
src/parser/mod.rs Outdated Show resolved Hide resolved
@lovasoa
Copy link
Contributor Author

lovasoa commented Oct 13, 2024

I changed the code to use maybe_parse, which is indeed much cleaner and resolves both your points. Thanks @iffyio !

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

@lovasoa
Copy link
Contributor Author

lovasoa commented Oct 14, 2024

@alamb , the test failure does not seem to be related to the contents of the pr.

/home/runner/.cargo/bin/cargo-tarpaulin: error while loading shared libraries: libssl.so.1.1: cannot open shared object file: No such file or directory

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lovasoa and @iffyio

@alamb alamb merged commit 7c20d4a into apache:main Oct 14, 2024
9 of 10 checks passed
@lovasoa
Copy link
Contributor Author

lovasoa commented Oct 14, 2024

Thanks for merging, @alamb !

@lovasoa lovasoa deleted the parse_set_role_as_variable branch October 14, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants