-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hive: support for special not expression !a
and raise error for a!
factorial operator
#1472
base: main
Are you sure you want to change the base?
Conversation
c0fac44
to
ab78bc2
Compare
Pull Request Test Coverage Report for Build 11303950713Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
src/parser/mod.rs
Outdated
@@ -1174,6 +1175,14 @@ impl<'a> Parser<'a> { | |||
), | |||
}) | |||
} | |||
Token::ExclamationMark if !self.dialect.supports_factorial_operator() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Token::ExclamationMark if !self.dialect.supports_factorial_operator() => { | |
Token::ExclamationMark if self.dialect.supports_bang_not_operator() => { |
See comment a bit lower for rationale to have a dedicated api for this behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly, this comment looks unadressed? The new feature ideally has its own dialect
method. Otherwise it can get complicated to try to infer when a feature should take precedence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code has been re-pushed.
db466d2
to
2196dc1
Compare
@iffyio Thank you for your suggestions—I learned a lot from them, I've resubmitted an updated version of the code. When you have a moment, could you please review it? Thanks!:) |
src/parser/mod.rs
Outdated
@@ -1174,6 +1175,14 @@ impl<'a> Parser<'a> { | |||
), | |||
}) | |||
} | |||
Token::ExclamationMark if !self.dialect.supports_factorial_operator() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly, this comment looks unadressed? The new feature ideally has its own dialect
method. Otherwise it can get complicated to try to infer when a feature should take precedence
de68644
to
99910dd
Compare
…r a! factorial operator in Hive dialect
@iffyio Sorry, my oversight caused the code not to be merged. The code has been re-pushed. |
Closes: #1471
Closes: #1473