Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of ADD PROJECTION syntax for ClickHouse #1390

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

git-hulk
Copy link
Member

ClickHouse supports using the projections mechanism to optimize query execution, and allow to use ALTER TABLE to manipulate its projection behavior.

For the documentation, please refer to:

https://clickhouse.com/docs/en/sql-reference/statements/alter/projection#add-projection

ClickHouse supports using the projections mechanism to optimize query execution,
and allow to use `ALTER TABLE` to manipulate its projection behavior.

For the documentation, please refer to:

https://clickhouse.com/docs/en/sql-reference/statements/alter/projection#add-projection
@coveralls
Copy link

coveralls commented Aug 19, 2024

Pull Request Test Coverage Report for Build 10482200202

Details

  • 115 of 119 (96.64%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 89.162%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/ddl.rs 7 9 77.78%
src/parser/mod.rs 56 58 96.55%
Totals Coverage Status
Change from base Build 10418247467: 0.02%
Covered Lines: 28373
Relevant Lines: 31822

💛 - Coveralls

@git-hulk
Copy link
Member Author

cc @iffyio

src/parser/mod.rs Outdated Show resolved Hide resolved
@git-hulk git-hulk requested a review from iffyio August 21, 2024 02:06
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a cool syntax - thank you @git-hulk and @iffyio

@alamb alamb merged commit 19e694a into apache:main Aug 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants