Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PARTITION BY feature for PostgreSQL while parsing the create table statement #1338

Merged
merged 2 commits into from
Jul 13, 2024

Conversation

git-hulk
Copy link
Member

This closes #1281.

PARTITION BY has been supported but wasn't enabled for the PostgreSQL dialect, this PR only enables it and adds a test case to make sure it works well.

@coveralls
Copy link

coveralls commented Jul 10, 2024

Pull Request Test Coverage Report for Build 9902843006

Details

  • 47 of 52 (90.38%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 89.184%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_postgres.rs 29 34 85.29%
Totals Coverage Status
Change from base Build 9864598743: -0.005%
Covered Lines: 26832
Relevant Lines: 30086

💛 - Coveralls

src/parser/mod.rs Outdated Show resolved Hide resolved
@git-hulk git-hulk requested a review from iffyio July 12, 2024 05:19
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @git-hulk and @iffyio

@alamb alamb merged commit 993216f into apache:main Jul 13, 2024
10 checks passed
ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partition by not supported - postgre
4 participants