Add support for generated columns skipping 'GENERATED ALWAYS' keywords #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7052140096
💛 - Coveralls |
tobyhede
approved these changes
Nov 29, 2023
src/ast/ddl.rs
Outdated
| @@ -600,6 +600,8 @@ pub enum ColumnOption { | |||
| sequence_options: Option<Vec<SequenceOptions>>, | |||
| generation_expr: Option<Expr>, | |||
| generation_expr_mode: Option<GeneratedExpressionMode>, | |||
| /// false if 'GENERATED ALWAYS' is skipped (option starts with AS) | |||
| generated_kw: bool, | |||
There was a problem hiding this comment.
Personal preference, but I would be inclined to expand the name to generated_keyword for clarity.
There was a problem hiding this comment.
No problem, I've done that renaming.
|
LGTM |
7 tasks
alamb
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Looks good to me -- thank you @takluyver and thank you @tobyhede for the review
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLite, Mysql and DuckDB all let you skip the words
GENERATED ALWAYS, and useASto introduce a column generated from an expression. See the links in #1051 for details.I've introduced an extra field in
ColumnOption::Generated-generated_kwis true if theGENERATEDkeyword is present, and false if the SQL skips directly toAS. I'm not sure of the naming, but it's the best I've thought of so far. Currently, ifgeneration_expris None,generated_kwcan only be true (and is assumed to be when recreating the SQL).Perhaps a neater design would be to have different
ColumnOptionkinds for generated-from-expression vs. generated-from-sequence vs. whatever else. But that would require an API break again.Closes #1050.