Fix Docs #676
Merged
Fix Docs #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-J-Ward
force-pushed
the
fix-docs-2
branch
from
4a75798
to
6990224
Compare
|
Any clues on why |
There are *.rst files added which not covered by Apache license header. You need either put the generated folder under RAT exclusion or double check if those files needed in the repo |
This is the same underlying issue as apache#670. The new datafusion UDF functions don't properly handle optional arguments.
This should ensure that docs will still build on any merge but only push the generated HTML once it hits main.
Michael-J-Ward
force-pushed
the
fix-docs-2
branch
from
6990224
to
47ce279
Compare
|
Thanks @comphead. I had included some |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #675
Rationale for this change
What changes are included in this PR?
regex_replacefrom docs. This will be added back once upstream datafusion figures out optional arguments to UDFs.docsgithub action to run on pull requests but only deploy when it hits main.