Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable Comet shuffle with AQE coalesce partitions #651

Closed
wants to merge 31 commits into from

Conversation

viirya
Copy link
Member

@viirya viirya commented Jul 10, 2024

Which issue does this PR close?

Closes #387.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@viirya viirya changed the title chore: Remove COMET_SHUFFLE_ENFORCE_MODE_ENABLED chore: Enable Comet shuffle with AQE coalesce partitions Jul 10, 2024
@viirya viirya marked this pull request as draft July 10, 2024 20:36
@viirya
Copy link
Member Author

viirya commented Jul 10, 2024

Some Spark tests need to be updated. Marked this as a draft for now.

@viirya
Copy link
Member Author

viirya commented Jul 18, 2024

All Comet and TPCDS, TPCH tests are passed. Next, I will fix Spark SQL tests.

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 33.99%. Comparing base (4fe43ad) to head (3562b39).
Report is 7 commits behind head on main.

Files Patch % Lines
...ain/java/org/apache/comet/parquet/BatchReader.java 0.00% 1 Missing ⚠️
...l/comet/execution/arrow/CometArrowConverters.scala 0.00% 1 Missing ⚠️
...org/apache/comet/CometSparkSessionExtensions.scala 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #651      +/-   ##
============================================
+ Coverage     33.94%   33.99%   +0.05%     
+ Complexity      874      858      -16     
============================================
  Files           112      112              
  Lines         42916    42875      -41     
  Branches       9464     9461       -3     
============================================
+ Hits          14567    14576       +9     
+ Misses        25379    25304      -75     
- Partials       2970     2995      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viirya
Copy link
Member Author

viirya commented Aug 15, 2024

For the negative refcount issue reported by Java Arrow, I cannot reproduce it locally or even on internal CI (different platform other than ubuntu).

I'm not sure if it is related to the ubuntu platform the GitHub Actions uses. Because GitHub Actions only supports ubuntu for linux, I cannot try other linux os. Currently I can only try to use older ubuntu (20.04) and see it helps.

@viirya
Copy link
Member Author

viirya commented Aug 16, 2024

Close in favor of #834.

@viirya viirya closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Comet shuffle with AQE coalesce partitions
2 participants