Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid recursive call to canonicalizePlans #582

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

viirya
Copy link
Member

@viirya viirya commented Jun 17, 2024

Which issue does this PR close?

Closes #576.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@viirya viirya changed the title fix: Avoid resursive call to canonicalizePlans fix: Avoid resursive call to canonicalizePlans Jun 17, 2024
@viirya viirya changed the title fix: Avoid resursive call to canonicalizePlans fix: Avoid recursive call to canonicalizePlans Jun 17, 2024
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @viirya. I confirmed that this fixes the issue,

@andygrove andygrove merged commit 741d00c into apache:main Jun 17, 2024
43 checks passed
@viirya viirya deleted the fix_recursive_canonicalize branch June 17, 2024 19:32
himadripal pushed a commit to himadripal/datafusion-comet that referenced this pull request Sep 7, 2024
* fix: Avoid resursive call to canonicalizePlans

* Add comment

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite recursion when calling canonicalized on query plan for TPC-H q8
2 participants