build: Drop Spark 3.2 support #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @andygrove @viirya @kazuyukitanimura @parthchandra |
eejbyfeldt
reviewed
Jun 17, 2024
spark/src/main/scala/org/apache/spark/sql/comet/CometBatchScanExec.scala
Show resolved
Hide resolved
spark/src/main/spark-3.x/org/apache/spark/sql/comet/shims/ShimCometScanExec.scala
Outdated
Show resolved
Hide resolved
spark/src/main/spark-3.x/org/apache/spark/sql/comet/shims/ShimCometScanExec.scala
Show resolved
Hide resolved
spark/src/main/spark-3.x/org/apache/spark/sql/comet/shims/ShimCometScanExec.scala
Outdated
Show resolved
Hide resolved
kazuyukitanimura
approved these changes
Jun 18, 2024
viirya
reviewed
Jun 18, 2024
| } | ||
|
|
||
| // TODO: remove after dropping Spark 3.2 support and directly call new FileScanRDD | ||
| // TODO: remove after dropping Spark 3.4 support and directly call new FileScanRDD |
There was a problem hiding this comment.
3.4 or 3.3? I don't see we explicitly mention 3.4 in other places.
There was a problem hiding this comment.
Should be 3.4 because FileScanRDD has a different signature in 4.0
Here is the 4.0 signature
class FileScanRDD(
@transient private val sparkSession: SparkSession,
readFunction: (PartitionedFile) => Iterator[InternalRow],
@transient val filePartitions: Seq[FilePartition],
val readSchema: StructType,
val metadataColumns: Seq[AttributeReference] = Seq.empty,
metadataExtractors: Map[String, PartitionedFile => Any] = Map.empty,
options: FileSourceOptions = new FileSourceOptions(CaseInsensitiveMap(Map.empty)))
Here is the 3.4 signature
class FileScanRDD(
@transient private val sparkSession: SparkSession,
readFunction: (PartitionedFile) => Iterator[InternalRow],
@transient val filePartitions: Seq[FilePartition],
val readSchema: StructType,
val metadataColumns: Seq[AttributeReference] = Seq.empty,
options: FileSourceOptions = new FileSourceOptions(CaseInsensitiveMap(Map.empty)))
There was a problem hiding this comment.
How about 3.3? Is it also different to Spark 3.4?
There was a problem hiding this comment.
yes, 3.3 is also different from 3.4. Here is the 3.3 signature
class FileScanRDD(
@transient private val sparkSession: SparkSession,
readFunction: (PartitionedFile) => Iterator[InternalRow],
@transient val filePartitions: Seq[FilePartition],
val readSchema: StructType,
val metadataColumns: Seq[AttributeReference] = Seq.empty)
Spark 3.5 has the same signature as Spark 4.0
There was a problem hiding this comment.
Yea, that is why I asked about
remove after dropping Spark 3.4 support ...
Isn't it Spark 3.3/Spark 3.4?
There was a problem hiding this comment.
Ok Let me rewrite this to make it more clear
viirya
approved these changes
Jun 18, 2024
|
Thanks, everyone! |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
* build: Drop Spark 3.2 support * remove un-used import * fix BloomFilterMightContain * revert the changes for TimestampNTZType and PartitionIdPassthrough * address comments and remove more 3.2 related code * remove un-used import * put back newDataSourceRDD * remove un-used import and put back lazy val partitions * address comments * Trigger Build * remove the missed 3.2 pipeline * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes 565.
Rationale for this change
What changes are included in this PR?
How are these changes tested?