fix: requested character too large for encoding in chr function #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…256, also added test case
|
@andygrove this is ready for review. |
andygrove
reviewed
Jun 11, 2024
andygrove
reviewed
Jun 11, 2024
andygrove
reviewed
Jun 11, 2024
Co-authored-by: Andy Grove <andygrove73@gmail.com>
andygrove
reviewed
Jun 11, 2024
Co-authored-by: Andy Grove <andygrove73@gmail.com>
vaibhawvipul
changed the title
andygrove
changed the title
| None => { | ||
| exec_err!("requested character too large for encoding.") | ||
| .map(|integer| { | ||
| if integer < 0 { |
There was a problem hiding this comment.
@andygrove can we use unlikely (requires nightly) to indicate a less likely branch
There was a problem hiding this comment.
I thought we are moving to stable?
viirya
reviewed
Jun 12, 2024
vaibhawvipul
commented
Jun 13, 2024
andygrove
reviewed
Jun 14, 2024
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
Outdated
Show resolved
Hide resolved
andygrove
reviewed
Jun 14, 2024
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Andy Grove <andygrove73@gmail.com>
andygrove
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Thanks @vaibhawvipul. I think this addresses the feedback from @viirya so I will plan on merging this soon if there is no other feedback.
viirya
approved these changes
Jun 14, 2024
|
Thanks @vaibhawvipul |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
…he#552) * adding support for negative integers and modulo checks for int above 256, also added test case * fix test case to avoid cast integer overflow error * Update core/src/execution/datafusion/expressions/scalar_funcs/chr.rs Co-authored-by: Andy Grove <andygrove73@gmail.com> * returning negative ints as empty string earlier * adding scalar test and removing unreachable code * Update core/src/execution/datafusion/expressions/scalar_funcs/chr.rs Co-authored-by: Andy Grove <andygrove73@gmail.com> * Update spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala Co-authored-by: Andy Grove <andygrove73@gmail.com> * add a test case where integer & 0xFF == 0 --------- Co-authored-by: Andy Grove <andygrove73@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #480 .
Rationale for this change
improves compatibility with spark
What changes are included in this PR?
How are these changes tested?
Test cases added, all the existing tests pass.