test: Add tests for Scalar and Inverval values for UnaryMinus #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
Outdated
Show resolved
Hide resolved
kazuyukitanimura
changed the title
kazuyukitanimura
approved these changes
Jun 11, 2024
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
Outdated
Show resolved
Hide resolved
|
pending ci |
|
Thanks @vaibhawvipul and @kazuyukitanimura |
andygrove
reviewed
Jun 11, 2024
| @@ -1635,7 +1637,7 @@ class CometExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelper { | |||
| case (Some(sparkException), Some(cometException)) => | |||
| assert(sparkException.getMessage.contains(dtype + " overflow")) | |||
| assert(cometException.getMessage.contains(dtype + " overflow")) | |||
| case (None, None) => assert(true) // got same outputs | |||
| case (None, None) => checkSparkAnswerAndOperator(sql(query)) | |||
There was a problem hiding this comment.
nit: we call checkSparkMaybeThrows,, and if that doesn't fail, then we call checkSparkAnswerAndOperator. I think this could all be streamlined, but this is beyond the scope of this PR
andygrove
approved these changes
Jun 11, 2024
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
…#538) * adding scalar tests * refactor and test for interval * ci checks fixed * running operator checks when no error * removing redundant sqlconf * fix ci errorsg * moving interval test to array section * ci fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #508 .
Rationale for this change
Improves test coverage for various unary minus.
What changes are included in this PR?
Tests for scalar values and intervals.
How are these changes tested?
All tests pass.