fix: Input batch to ShuffleRepartitioner.insert_batch should not be larger than configured batch size #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advancedxy
reviewed
Jun 6, 2024
…arger than configured batch size
viirya
force-pushed
the
fix_insert_large_batch
branch
from
0e5bb68
to
b38b932
Compare
|
Thank you @sunchao |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
…arger than configured batch size (apache#523) * fix: Input batch to ShuffleRepartitioner.insert_batch should not be larger than configured batch size * Add test * For review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #498.
Rationale for this change
What changes are included in this PR?
How are these changes tested?