-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add specific fuzz tests for cast and try_cast and fix NPE found during fuzz testing #514
Conversation
optExprWithInfo(optExpr, expr, null, srcCast, trimCast) | ||
optExprWithInfo(optExpr, expr, srcCast, trimCast) | ||
} else { | ||
val optExpr = scalarExprToProto(trimType, srcExpr) | ||
optExprWithInfo(optExpr, expr, null, srcCast) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes an NPE that was discovered during fuzz testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
} else { | ||
val optExpr = scalarExprToProto(trimType, srcExpr) | ||
optExprWithInfo(optExpr, expr, null, srcCast) | ||
optExprWithInfo(optExpr, expr, srcCast) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding and fixing this Andy!
@kazuyukitanimura @huaxingao Could I get a committer review please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
… during fuzz testing (apache#514) * Varius improvements to fuzz testing tool * Fix NPE in QueryPlanSerde handling of trim expression * format
Which issue does this PR close?
N/A
Rationale for this change
Ongoing improvements to fuzz testing.
What changes are included in this PR?
cast
andtry_cast
How are these changes tested?
Manual testing