feat: Add specific fuzz tests for cast and try_cast and fix NPE found during fuzz testing #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
commented
Jun 4, 2024
Comment on lines
-2172
to
-2175
| optExprWithInfo(optExpr, expr, null, srcCast, trimCast) | ||
| optExprWithInfo(optExpr, expr, srcCast, trimCast) | ||
| } else { | ||
| val optExpr = scalarExprToProto(trimType, srcExpr) | ||
| optExprWithInfo(optExpr, expr, null, srcCast) |
There was a problem hiding this comment.
This fixes an NPE that was discovered during fuzz testing
parthchandra
approved these changes
Jun 4, 2024
| } else { | ||
| val optExpr = scalarExprToProto(trimType, srcExpr) | ||
| optExprWithInfo(optExpr, expr, null, srcCast) | ||
| optExprWithInfo(optExpr, expr, srcCast) |
There was a problem hiding this comment.
Thanks for finding and fixing this Andy!
|
@kazuyukitanimura @huaxingao Could I get a committer review please |
huaxingao
approved these changes
Jun 4, 2024
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
… during fuzz testing (apache#514) * Varius improvements to fuzz testing tool * Fix NPE in QueryPlanSerde handling of trim expression * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Ongoing improvements to fuzz testing.
What changes are included in this PR?
castandtry_castHow are these changes tested?
Manual testing