feat: Improve cast compatibility tests and docs #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
commented
May 4, 2024
| @@ -347,7 +364,7 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper { | |||
| Short.MaxValue.toFloat, | |||
| 0.0f) ++ | |||
| Range(0, dataSize).map(_ => r.nextFloat()) | |||
| withNulls(values).toDF("a") | |||
| castTest(withNulls(values).toDF("a"), DataTypes.StringType) | |||
There was a problem hiding this comment.
Fixing a regression that was introduced in #346
andygrove
commented
May 4, 2024
| @@ -401,7 +418,7 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper { | |||
| Double.NegativeInfinity, | |||
| 0.0d) ++ | |||
| Range(0, dataSize).map(_ => r.nextDouble()) | |||
| withNulls(values).toDF("a") | |||
| castTest(withNulls(values).toDF("a"), DataTypes.StringType) | |||
There was a problem hiding this comment.
Fixing a regression that was introduced in #346
andygrove
commented
May 4, 2024
| @@ -795,7 +812,7 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper { | |||
| Seq( | |||
| "2024-01-01T12:34:56.123456", | |||
| "2024-01-01T01:00:00Z", | |||
| "2024-12-31T01:00:00-02:00", | |||
| "9999-12-31T01:00:00-02:00", | |||
There was a problem hiding this comment.
Just making sure we have a wider range of years being tested
andygrove
commented
May 4, 2024
| if (line.trim == "<!--CAST_TABLE-->") { | ||
| w.write("| From Type | To Type | Compatible? | Notes |\n".getBytes) | ||
| w.write("|-|-|-|-|\n".getBytes) | ||
| if (line.trim == "<!--COMPAT_CAST_TABLE-->") { |
There was a problem hiding this comment.
There was previously one table, but now we show separate tables for compatible and incompatible.
andygrove
commented
May 4, 2024
| @@ -253,7 +253,8 @@ class CometExecSuite extends CometTestBase { | |||
| dataTypes.map { subqueryType => | |||
| withSQLConf( | |||
| CometConf.COMET_EXEC_SHUFFLE_ENABLED.key -> "true", | |||
| CometConf.COMET_COLUMNAR_SHUFFLE_ENABLED.key -> "true") { | |||
| CometConf.COMET_COLUMNAR_SHUFFLE_ENABLED.key -> "true", | |||
| CometConf.COMET_CAST_ALLOW_INCOMPATIBLE.key -> "true") { | |||
There was a problem hiding this comment.
This test needs binary -> string casts
|
@viirya @snmvaughan This PR incorporates some of the feedback from #362 |
viirya
approved these changes
May 7, 2024
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #286
Rationale for this change
What changes are included in this PR?
Docs Preview
We have a table of compatible casts, followed by:
How are these changes tested?
Tested docs locally.