feat: Disable cast string to timestamp by default #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
viirya
approved these changes
Apr 29, 2024
| @@ -365,6 +365,13 @@ object CometConf { | |||
| .booleanConf | |||
| .createWithDefault(false) | |||
|
|
|||
| val COMET_CAST_STRING_TO_TIMESTAMP: ConfigEntry[Boolean] = conf( | |||
There was a problem hiding this comment.
Wondering if we should have this configuration at all? If users turn this on they could end up with incorrect data?
37 tasks
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #328
Rationale for this change
Casting from string to timestamp can cause incorrect results especially regarding timezone and could potentially lead to data corruption. We should disable it by default until we have fixed #328
What changes are included in this PR?
How are these changes tested?
New test added