chore: Replace deprecated temporal methods #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
=========================================
Coverage 33.32% 33.32%
Complexity 769 769
=========================================
Files 107 107
Lines 37037 37037
Branches 8106 8106
=========================================
+ Hits 12341 12342 +1
Misses 22098 22098
+ Partials 2598 2597 -1 ☔ View full report in Codecov by Sentry. |
viirya
approved these changes
Mar 28, 2024
|
Merged. Thanks. |
viirya
reviewed
Mar 28, 2024
| @@ -178,7 +178,7 @@ fn pre_timestamp_cast(array: ArrayRef, timezone: String) -> ArrayRef { | |||
| let datetime = as_datetime::<TimestampMicrosecondType>(value).unwrap(); | |||
| let offset = tz.offset_from_utc_datetime(&datetime).fix(); | |||
| let datetime = datetime + offset; | |||
| datetime.timestamp_micros() | |||
There was a problem hiding this comment.
Hmm, it this deprecated? I saw only timestamp_nanos is deprecated?
snmvaughan
added a commit
to snmvaughan/arrow-datafusion-comet
that referenced
this pull request
Apr 4, 2024
* chore: Handle deprecation of timestamp_micros() * chore: Handle deprecation of seconds() --------- Co-authored-by: Steve Vaughan Jr <s_vaughan@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
For builds that fail when there are deprecated warnings, this eliminates build failures.
What changes are included in this PR?
Replaces deprecated methods with equivalent implementations.
How are these changes tested?
Tested locally