build: Avoid confusion by using profile with clean #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logs can include spark and scala versions that don't match the specified profile, which can lead to confusion. This change includes the profile when running `make clean` to ensure consistency.
sunchao
approved these changes
Mar 20, 2024
viirya
approved these changes
Mar 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
=========================================
Coverage 33.41% 33.41%
Complexity 768 768
=========================================
Files 107 107
Lines 36329 36329
Branches 7935 7935
=========================================
Hits 12138 12138
Misses 21643 21643
Partials 2548 2548 ☔ View full report in Codecov by Sentry. |
|
Merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The logs can include spark and scala versions that don't match the specified profile, which can lead to confusion. This change includes the profile when running
make cleanto ensure consistency.What changes are included in this PR?
Adds
$(PROFILES)to themake cleantaskHow are these changes tested?
Manually