Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attempt to divide by zero error on decimal division #172

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

viirya
Copy link
Member

@viirya viirya commented Mar 6, 2024

Which issue does this PR close?

Closes #171.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@viirya
Copy link
Member Author

viirya commented Mar 6, 2024

cc @sunchao

@viirya viirya changed the title fix: attempt to divide by zero error on decimal division fix: attempt to divide by zero error on decimal division Mar 6, 2024
@viirya viirya changed the title fix: attempt to divide by zero error on decimal division fix: attempt to divide by zero error on decimal division Mar 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.29%. Comparing base (9a58880) to head (2d7fac1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #172      +/-   ##
============================================
+ Coverage     33.27%   33.29%   +0.01%     
- Complexity      763      766       +3     
============================================
  Files           105      107       +2     
  Lines         35373    35379       +6     
  Branches       7663     7657       -6     
============================================
+ Hits          11772    11778       +6     
- Misses        21151    21155       +4     
+ Partials       2450     2446       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viirya
Copy link
Member Author

viirya commented Mar 6, 2024

cc @kazuyukitanimura

Copy link
Contributor

@kazuyukitanimura kazuyukitanimura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I wonder if we need a similar fix for modulo operation

@viirya
Copy link
Member Author

viirya commented Mar 6, 2024

LGTM I wonder if we need a similar fix for modulo operation

Thanks for review.

I think for modulo operation, we don't implement the operation in Comet but delegate to DataFusion?
I just tested it and looks okay. Let me also add it in the test.

@kazuyukitanimura
Copy link
Contributor

Great, thanks for confirming

Copy link
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viirya viirya merged commit ccc4a95 into apache:main Mar 6, 2024
19 checks passed
@viirya
Copy link
Member Author

viirya commented Mar 6, 2024

Merged. Thanks.

@viirya viirya deleted the fix_decimal_div branch March 6, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

attempt to divide by zero error on decimal division
4 participants