test: Add some fuzz testing for cast operations #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will close and reopen this to trigger CI. |
viirya
reviewed
Feb 14, 2024
Comment on lines
22
to
25
| import org.apache.spark.sql.execution.adaptive.AdaptiveSparkPlanHelper | ||
| import org.apache.spark.sql.{CometTestBase, DataFrame, SaveMode} | ||
| import org.apache.spark.sql.functions.col | ||
| import org.apache.spark.sql.types.{DataType, DataTypes} |
There was a problem hiding this comment.
@sunchao Do we run style check in CI? Looks like the import order looks not correct?
There was a problem hiding this comment.
I need to double-check. The scalafix check is done here but I'm not sure if the import order is checked by something else.
There was a problem hiding this comment.
Oh it's because the scalastyle-maven-plugin is disabled. Let me try to re-enable it.
sunchao
changed the title
sunchao
approved these changes
Feb 16, 2024
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some fuzz tests for cast operations. I only covered a few data types, but expanding this to cover more types should be simple.
Many tests are currently failing, so those ones are ignored for now.