-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Reduce end-to-end test time #109
Merged
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b7e7444
test: Reduce shuffle test time
sunchao 6ce3f31
fix
sunchao 70d6fea
remove non-fast merge test combination
sunchao 26e69d7
reduce time in shuffle
sunchao 102bdfe
reduce time in aggregate
sunchao edd03a8
try parallel
sunchao f1b4f9b
fix format
sunchao c2cde0d
fix format
sunchao b3b14e9
fix config
sunchao 510a4d1
revert pom changes
sunchao 7b58ae5
review
sunchao 2ec3d3e
more
sunchao dbbdc93
update
sunchao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are columns
_1
,_2
... different to each other? If so, seems this removesSUM(_3)
andSUM(_4)
and also misses someSUM(DISTINCT xx)
? Because previously it tests all columns with all aggregate expressions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the code path is pretty much the same though, so I thought it is fine to lose some precision here.