Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Remove no longer needed comments.

Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
  • Loading branch information
eejbyfeldt and viirya committed Jun 20, 2024
1 parent 76420f6 commit 8d3c0c5
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion core/src/jvm_bridge/batch_iterator.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ impl<'a> CometBatchIterator<'a> {
pub const JVM_CLASS: &'static str = "org/apache/comet/CometBatchIterator";

pub fn new(env: &mut JNIEnv<'a>) -> JniResult<CometBatchIterator<'a>> {
// Get the global class reference
let class = env.find_class(Self::JVM_CLASS)?;

Ok(CometBatchIterator {
Expand Down
1 change: 0 additions & 1 deletion core/src/jvm_bridge/comet_exec.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ impl<'a> CometExec<'a> {
pub const JVM_CLASS: &'static str = "org/apache/spark/sql/comet/CometScalarSubquery";

pub fn new(env: &mut JNIEnv<'a>) -> JniResult<CometExec<'a>> {
// Get the global class reference
let class = env.find_class(Self::JVM_CLASS)?;

Ok(CometExec {
Expand Down
1 change: 0 additions & 1 deletion core/src/jvm_bridge/comet_metric_node.rs
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ impl<'a> CometMetricNode<'a> {
pub const JVM_CLASS: &'static str = "org/apache/spark/sql/comet/CometMetricNode";

pub fn new(env: &mut JNIEnv<'a>) -> JniResult<CometMetricNode<'a>> {
// Get the global class reference
let class = env.find_class(Self::JVM_CLASS)?;

Ok(CometMetricNode {
Expand Down

0 comments on commit 8d3c0c5

Please sign in to comment.