Add GCS and Azure support #308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 2, 2022
Closed
|
@onthebridgetonowhere This all looks reasonable. Were you able to test this to make sure it works? |
|
@andygrove good point. Unfortunately, I do not have the possibility of testing these. I'd have to look into how to test these services as I don't have access/accounts to them. If you have access to GCP and Azure, feel free to try them. |
|
Moving this to draft for now |
|
It looks like progress is stalled here, so I am going to go ahead and close this. We can re-open if anyone wants to pick this up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #294 and #293.
Rationale for this change
Adds support for Azure & GCS
What changes are included in this PR?
Just what's required for supporting Azure & GCS
Are there any user-facing changes?
No